Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: skip is verified check for script/create deployments #6523

Merged

Conversation

mattsse
Copy link
Member

@mattsse mattsse commented Dec 5, 2023

per #6426

for script/create we want to skip is verified check (often false positives due to similar bytecode) and always try verification

@mattsse mattsse force-pushed the matt/flip-skip-verified-check-in-script branch from bb0a187 to 7f15d83 Compare December 5, 2023 11:43
Copy link
Member

@Evalir Evalir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, this is a big source of false positives

@Evalir Evalir changed the title chore: skip is verified check for script deployments chore: skip is verified check for script/create deployments Dec 5, 2023
@mattsse mattsse merged commit dcf25ff into foundry-rs:master Dec 5, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants